Almost there
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/17229005/diff/163003/src/hydrogen.h#newcode1019
src/hydrogen.h:1019: static Representation ToRepresentation(Handle<Type>
type);
I think it makes sense to move ToRepresentation(Handle<Type> type) to
property_details.h where as a static helper function on Representation,
e.g. FromType(). There is no reason it should be limited to
HGraphBuilder.
https://codereview.chromium.org/17229005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
