https://codereview.chromium.org/17600006/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/17600006/diff/1/include/v8.h#newcode1047
include/v8.h:1047: V8_DEPRECATED(Local<Value> Id());
Won't this break Blink compilation?
https://codereview.chromium.org/17600006/diff/1/include/v8.h#newcode2358
include/v8.h:2358: int ScriptId() const;
Same question.
https://codereview.chromium.org/17600006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/17600006/diff/1/src/api.cc#newcode4355
src/api.cc:4355: return i::Script::kNoScriptId;
This should be a public constant.
https://codereview.chromium.org/17600006/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/17600006/diff/1/src/heap.h#newcode178
src/heap.h:178: V(Smi, last_script_id, LastScriptId)
\
Why not make it simple int property and probably move into Factory?
https://codereview.chromium.org/17600006/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/17600006/diff/1/test/cctest/test-api.cc#newcode16657
test/cctest/test-api.cc:16657: CHECK_EQ(script->GetId(),
foo->ScriptId());
We should keep old tests as well until the API is deleted.
https://codereview.chromium.org/17600006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
