comments addressed
https://codereview.chromium.org/17600006/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/17600006/diff/1/include/v8.h#newcode1047
include/v8.h:1047: V8_DEPRECATED(Local<Value> Id());
On 2013/06/25 11:57:38, Yury Semikhatsky wrote:
Won't this break Blink compilation?
Done.
https://codereview.chromium.org/17600006/diff/1/include/v8.h#newcode2358
include/v8.h:2358: int ScriptId() const;
On 2013/06/25 11:57:38, Yury Semikhatsky wrote:
Same question.
Done.
https://codereview.chromium.org/17600006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/17600006/diff/1/src/api.cc#newcode4355
src/api.cc:4355: return i::Script::kNoScriptId;
On 2013/06/25 11:58:39, Jakob wrote:
nit: {} please
Done.
https://codereview.chromium.org/17600006/diff/1/src/api.cc#newcode4355
src/api.cc:4355: return i::Script::kNoScriptId;
On 2013/06/25 11:57:38, Yury Semikhatsky wrote:
This should be a public constant.
Done.
https://codereview.chromium.org/17600006/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/17600006/diff/1/src/heap.h#newcode178
src/heap.h:178: V(Smi, last_script_id, LastScriptId)
\
On 2013/06/25 11:57:38, Yury Semikhatsky wrote:
Why not make it simple int property and probably move into Factory?
factory is a memberless class. So it cannot be used for storing
last_script_id.
https://codereview.chromium.org/17600006/diff/1/src/heap.h#newcode1444
src/heap.h:1444: inline void SetLastScriptId(int last_script_id);
On 2013/06/25 11:58:39, Jakob wrote:
I don't think we need this any more, since AFAICT you removed the only
call site
in factory.cc.
Done.
https://codereview.chromium.org/17600006/diff/1/src/heap.h#newcode1444
src/heap.h:1444: inline void SetLastScriptId(int last_script_id);
On 2013/06/25 11:58:39, Jakob wrote:
I don't think we need this any more, since AFAICT you removed the only
call site
in factory.cc.
Done.
https://codereview.chromium.org/17600006/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/17600006/diff/1/src/objects.h#newcode5823
src/objects.h:5823: static const int kNoScriptId = 0;
On 2013/06/25 11:58:39, Jakob wrote:
Please move this somewhere else (e.g. to the beginning of the class
definition,
by the enums), as it has nothing to do with the object layout
description.
Since this only has a single use in api.cc, it would also be fine with
me to
just inline the value (maybe as a function-local constant to be more
descriptive
than a plain '0' literal).
It was moved to v8::Script.
https://codereview.chromium.org/17600006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
