https://codereview.chromium.org/17600006/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/17600006/diff/1/src/api.cc#newcode4355
src/api.cc:4355: return i::Script::kNoScriptId;
nit: {} please
https://codereview.chromium.org/17600006/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/17600006/diff/1/src/heap.h#newcode1444
src/heap.h:1444: inline void SetLastScriptId(int last_script_id);
I don't think we need this any more, since AFAICT you removed the only
call site in factory.cc.
https://codereview.chromium.org/17600006/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/17600006/diff/1/src/objects.h#newcode5823
src/objects.h:5823: static const int kNoScriptId = 0;
Please move this somewhere else (e.g. to the beginning of the class
definition, by the enums), as it has nothing to do with the object
layout description.
Since this only has a single use in api.cc, it would also be fine with
me to just inline the value (maybe as a function-local constant to be
more descriptive than a plain '0' literal).
https://codereview.chromium.org/17600006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
