[v8-dev] Re: CPUProfiler: It is not clear why we are using Handle for scriptId. Lets flip it into Smi/in… (issue 17600006)

Tue, 25 Jun 2013 07:32:39 -0700

LGTM with a comment.

Please avoid rebasing between patch sets as it screws up the diff view.


https://codereview.chromium.org/17600006/diff/2004/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/17600006/diff/2004/include/v8.h#newcode2363
include/v8.h:2363: V8_DEPRECATED(Handle<Value> GetScriptId() const);
I guess you meant to remove the V8_DEPRECATED annotation from the
function declaration.

https://codereview.chromium.org/17600006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to