Comment #11 on issue 2741 by [email protected]: max_opt_count is
implemented using the wrong kind of limit
http://code.google.com/p/v8/issues/detail?id=2741
I don't think so? Of course you know more of the codebase, but I looked to
see if having that condition checked there would prevent the stub from
maturing and graduating into being monomorphic, and I don't believe I saw
any place that including that single condition there prevents transitioning
into being monomorphic. I think the code path is set per Stub right? If it
can't ever become monomorphic in the first place why keep trying to
optimize it or even worry about it being monomorphic? So I'm trying to stop
the attempted full optimizing compile there when it'll never help in the
future of that function.
I tried to convey my intent with words, but that didn't exactly work :(
Hopefully though, you'll see my intent with this bogus patch which doesn't
actually work but I'm glad my it's showing you my thought process to try
and make sure that pre-monomorphic cases don't get put into the
recompilation scheduler.
Just to let you know, having those tests there actually doesn't make any
regressions on benchmark speeds when I have done compiles, seems to speed
CodeLoad by a bit... so it can't be that terrible, I just haven't got it
right yet.
I must say your code structure is quite crazy and fun but VERY
tightly-knit. My plan to get this to work is to use a code->ic_state() !=
PREMONOMORPHIC condition at those test sites similar to
https://code.google.com/p/v8/codesearch#v8/trunk/src/type-info.cc&l=339 ,
but It's my 1st time in this codebase so I'm stumbling around a fair bit
trying to pass in a "Handle<Code> code" bits to access the stub info for
the test.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
