Comment #15 on issue 2741 by [email protected]: max_opt_count is
implemented using the wrong kind of limit
http://code.google.com/p/v8/issues/detail?id=2741
:S To avoid patching code that is run only once...
Sure it's a precursor stage to becoming monomorphic but setting the
monomorphic condition will happen before keeping it in a premonomorphic
state for too long preventing it from being caught in an un-optimizable
state right?
It's one of your assumptions in code comments somewhere... that you wont
stay in a premonomorphic state long and code is prepared for it to become
monomorphic and is explicitly set as premonomorphic but the behaviour
doesn't utilize the state right(I think) which is why I've thought it
reasonable to bring up and consider it a bug and even try fixing this
myself.
Why try to keep optimizing the stub if it can never succeed in an actual
monomorphic transition? Whenever the cache is cleared it'll try again
anyway so I'm just proposing to be more strict on how frequently you call
ResetForNewContext.
BTW it's funny seeing TODO(jkummerow)'s generously peppered around and...
no need to be rude.. sure I'm a newby to the codebase, and I'm having a
slight bumpy time on day #2, but I find it fun and I believe there is at
least reason to try this as the change is maybe 10-30 mins max from an
experienced engineer's fingers such as yourself.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
