https://codereview.chromium.org/20241005/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/20241005/diff/1/src/hydrogen-instructions.h#newcode1154
src/hydrogen-instructions.h:1154: return !type().IsString() &&
representation().IsTagged();
This predicate looks broken. Shouldn't that be type().IsNumber() here?
https://codereview.chromium.org/20241005/diff/1/src/hydrogen-instructions.h#newcode6481
src/hydrogen-instructions.h:6481: virtual bool IsDeletable() const {
nit: This should be private, please move it back down.
https://codereview.chromium.org/20241005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):
https://codereview.chromium.org/20241005/diff/1/src/hydrogen.cc#oldcode9081
src/hydrogen.cc:9081: // Fast support for StringAdd.
nit: Can we get the comment back?
https://codereview.chromium.org/20241005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
