https://codereview.chromium.org/20241005/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/20241005/diff/1/src/hydrogen-instructions.h#newcode6481
src/hydrogen-instructions.h:6481: virtual bool IsDeletable() const {
On 2013/07/25 14:43:18, Michael Starzinger wrote:
nit: This should be private, please move it back down.
Done.
https://codereview.chromium.org/20241005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (left):
https://codereview.chromium.org/20241005/diff/1/src/hydrogen.cc#oldcode9081
src/hydrogen.cc:9081: // Fast support for StringAdd.
On 2013/07/25 14:43:18, Michael Starzinger wrote:
nit: Can we get the comment back?
Well, I wanted that one for my code offsets, but I suppose :(
('twas a vestige of trying to delete that method, actually!)
https://codereview.chromium.org/20241005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
