On 2013/07/29 11:48:08, Sven Panne wrote:
LGTM with nits.
https://codereview.chromium.org/20241005/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/20241005/diff/13001/src/hydrogen-instructions.h#newcode427
src/hydrogen-instructions.h:427: switch (type_) {
The usual pattern within v8 is:
switch (foo) {
case BLAH:
case BLOH:
return 42;
case FOO:
return 271828;
}
UNREACHABLE();
return 0; // Make -Wall happy
I'll leave it up to you if you change it or not.
In this case, one case does a break and thus falls through to return at the
end.
https://codereview.chromium.org/20241005/diff/13001/src/hydrogen-instructions.h#newcode428
src/hydrogen-instructions.h:428: case kTaggedPrimitive: // fallthru
Align.
Done.
https://codereview.chromium.org/20241005/diff/13001/test/mjsunit/compiler/dead-string-add-warm.js
File test/mjsunit/compiler/dead-string-add-warm.js (right):
https://codereview.chromium.org/20241005/diff/13001/test/mjsunit/compiler/dead-string-add-warm.js#newcode50
test/mjsunit/compiler/dead-string-add-warm.js:50: assertTrue(dead1(33,
32) ==
33);
assertEquals(33, dead1(33, 32);
Likewise below and in other tests.
Done.
https://codereview.chromium.org/20241005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
