This is an itsy-bitsy fragile, I must say. :D
https://codereview.chromium.org/20241005/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/20241005/diff/5001/src/hydrogen-instructions.h#newcode1150
src/hydrogen-instructions.h:1150: return
representation().IsSmiOrInteger32() || representation().IsDouble();
Discusssed with Sven: This whole line should be negated.
https://codereview.chromium.org/20241005/diff/5001/src/hydrogen-instructions.h#newcode1152
src/hydrogen-instructions.h:1152: return !type().IsNonPrimitive();
Discusssed with Sven: What happens for type().IsTagged() here?
https://codereview.chromium.org/20241005/diff/5001/src/hydrogen-instructions.h#newcode1160
src/hydrogen-instructions.h:1160: return
representation().IsSmiOrInteger32() || representation().IsDouble();
Likewise.
https://codereview.chromium.org/20241005/diff/5001/src/hydrogen-instructions.h#newcode1162
src/hydrogen-instructions.h:1162: return !type().IsNonPrimitive();
Likewise.
https://codereview.chromium.org/20241005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
