On 2013/07/25 22:22:05, danno wrote:
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.cc#newcode3697
src/hydrogen-instructions.cc:3697: if (has_external_value_) return
HType::None();
On 2013/07/25 21:09:11, Benedikt Meurer wrote:
> On 2013/07/25 18:35:57, danno wrote:
> > You should also look in HLoadExternalArrayPointer and make sure that
it
now
> > returns the type HType::None()
>
> Why? It's an external pointer, shouldn't it have
Representation::External
then?
HLoadExternalArrayPointer already does return Representation::External(),
it's
the HType that's not right. It seems you went through some trouble in
this CL
to
introduce HType::None so that HConstant with ExternalReferences have this
type,
and I think you should give that goodness to HLoadExternalArrayPointer.
It too
loads an external pointer, but instead of being constant, it's loaded
from a
typed array, but otherwise should be handled just like HConstant in this
external reference case.
Ah right, damn, this type vs representation thing is so confusing.
Done.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
