On 2013/07/25 19:03:51, danno wrote:
On 2013/07/25 18:54:39, Benedikt Meurer wrote:
> On 2013/07/25 18:35:56, danno wrote:
> > Almost there...
>
> Hm, no. I just noticed that HLoadNamedField and HStoreNamedField are
designed
to
> work with tagged objects (of course). I'm working on adding special
cases
for
> external memory access everywhere.
> There's one nasty issue, however: The HStoreNamedField instruction says
it
> requires tagged for the first parameter, which breaks the external
reference
> constant. This makes sense of course, since the
HLoadNamedField/HStoreNamedField
> instructions were designed to work on tagged object fields.
>
> Should I add HLoadExternal/HStoreExternal instead of adding special
cases to
> HLoad/StoreNamedField?
I don't like the idea of adding another instruction, even if it makes the
implementation of HLoad/StoreNamedField more complicated. Eventually,
those
instruction should become just HLoad/HStore, and all of the duplicate
store
eliminations and load coalescing that we do should work on any types. So,
similar to HConstant, it's worth the extra complexity to support external
addresses.
Ok, you've got a point there.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
