PTAL
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.cc#newcode3697
src/hydrogen-instructions.cc:3697: if (has_external_value_) return
HType::None();
On 2013/07/25 18:35:57, danno wrote:
You should also look in HLoadExternalArrayPointer and make sure that
it now
returns the type HType::None()
Why? It's an external pointer, shouldn't it have
Representation::External then?
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3477
src/hydrogen-instructions.h:3477: Representation r =
Representation::External());
On 2013/07/25 18:35:57, danno wrote:
r should never be settable for ExternalReferences, so remove the
parameter.
Done.
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3594
src/hydrogen-instructions.h:3594: bool HasExternalValue() const { return
has_external_value_; }
On 2013/07/25 18:35:57, danno wrote:
Call this HasExternalReferenceValue, it's more consistent
Done.
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3595
src/hydrogen-instructions.h:3595: ExternalReference ExternalValue()
const { return external_value_; }
On 2013/07/25 18:35:57, danno wrote:
Call this ExternalReferenceValue, it's more consistent
Done.
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3595
src/hydrogen-instructions.h:3595: ExternalReference ExternalValue()
const { return external_value_; }
On 2013/07/25 18:35:57, danno wrote:
Call this ExternalReferenceValue, it's more consistent
Done.
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3671
src/hydrogen-instructions.h:3671: bool has_external_value_ : 1;
On 2013/07/25 18:35:57, danno wrote:
has_external_reference_value_
Done.
https://codereview.chromium.org/19562003/diff/62001/src/hydrogen-instructions.h#newcode3678
src/hydrogen-instructions.h:3678: ExternalReference external_value_;
On 2013/07/25 18:35:57, danno wrote:
external_reference_value_
Done.
https://codereview.chromium.org/19562003/diff/62001/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):
https://codereview.chromium.org/19562003/diff/62001/src/ia32/lithium-ia32.h#newcode1210
src/ia32/lithium-ia32.h:1210:
On 2013/07/25 18:35:57, danno wrote:
nit: two carriage returns between the classes
Done.
https://codereview.chromium.org/19562003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
