https://codereview.chromium.org/49633004/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/49633004/diff/1/tools/run-tests.py#newcode57
tools/run-tests.py:57: ["--optimize-for-size"],
On 2013/10/29 12:43:31, Sven Panne wrote:
I am not sure if this is the right way to proceed, because it will
blow up our
test times significantly. Of course it would be a nice-to-have for
each flag,
but we can't afford this due to combinatorial explosion.
Perhaps we can have a runner on our waterfall with this flag enabled
instead?
I realize this will increase test time by about 25% - that's why I
didn't introduce it in the original CL - but I think it's important to
test with this flag enabled since it significantly changes generated
prologue code (and will change other generated code as more
optimizations are added), and the run-tests.py tests found some issues
which weren't apparent when running the JS benchmarks.
Having a runner (for each arch) with this flag enabled would be OK, but
are there extra runners available on which we can enable this flag (from
what I can see, there is only a single ARM runner on the V8 waterfall,
and I think we want to test both with and without the flag). Thoughts?
https://codereview.chromium.org/49633004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
