On 2013/10/29 15:52:31, Jakob wrote:
Adding new slave definitions increases cycle time quite considerably when two
or
more slaves have to share a VM. Instead, I'd suggest we model this as an
additional step that can be added to a few bots.

SGTM.

Ross, any input on which test suites are useful to run with the flag? mjsunit
probably, maybe test262, mozilla, or benchmarks. cctests, messages, and
preparser probably don't make much sense.

Actually it was cctests which found the previous two issues (bad interactions when SetFunctionEntryHook was non-null, and when the debugger was active), so I think it would make sense to include that. I'm not sure on the other tests, but
I agree messages and preparser are probably less interesting for this step.


https://codereview.chromium.org/49633004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to