On 2013/10/29 14:38:02, machenbach wrote:
I agree to Sven's suggestions. I can set up some builders on the
waterfall to
run a special config, once it is ready (just give me a note).
The "arm" builder that runs on real hardware is still quite fast, so I
suggest
we split it into two, one with and one without the flag (and optionally
one
being a release and the other a debug builder).
Then I just "randomly" select one builder of each other platform to run
with
that flag on.
Alternative: When passing in via --extra-flags=--optimize-for-size, every
test
variant will have the optimize-for-size flag set. Another option would be
to
extend the run-tests script with a new optimize-for-size parameter that,
only
when set, adds a variant with just optimize-for-size to the other three
variants. Then we would have +33% on a few selected builders, while also
keeping
the old test configurations.
What way to go depends on if you want the cross product of that flag with
the
other variants or not.
I would be happy with either of these suggestions, I'll chat you tomorrow to
decide on the best approach and work out the fine details of what needs to
be
done to get some of the runners running with this flag.
I know that this is annoying, and of course everybody likes to get good
test
coverage for his own new feature, but it is important to keep test times
manageable. Recently there was a very visible tendency that people
obviously
didn't run the test suite at all before committing, and we should actively
fight
that tendency...
This isn't just testing of a feature. The flag is used in production
devices
(low-end Android phones), so I think it is important to have continuous
testing
of this since it can interact in unexpected ways with seemingly unrelated
changes in code generation. I totally agree with you that we should keep
the
test runner quick to encourage people to run it before committing changes -
hopefully the suggestions yourself and Michael have made will provide the
best
of both worlds.
Thanks.
https://codereview.chromium.org/49633004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
