Adding new slave definitions increases cycle time quite considerably when
two or
more slaves have to share a VM. Instead, I'd suggest we model this as an
additional step that can be added to a few bots.
Ross, any input on which test suites are useful to run with the flag?
mjsunit
probably, maybe test262, mozilla, or benchmarks. cctests, messages, and
preparser probably don't make much sense.
Regarding variants, I'm not a huge fan of the existing variants anyway. It's
probably fine to run the new step with --no-variants
--extra-flags=--optimize-for-size.
(FWIW, I fully agree that adding a fourth variant is not an option. If
anything
we should remove one.)
https://codereview.chromium.org/49633004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
