https://codereview.chromium.org/48923002/diff/70001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/48923002/diff/70001/src/api.cc#newcode6201
src/api.cc:6201: return Utils::ToLocal(result);
On 2013/10/29 12:47:26, Yang wrote:
I think you could unify those two New functions by having a default
argument for
data like NULL or "\0".
Done (also for the Symbol class).
https://codereview.chromium.org/48923002/diff/70001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/48923002/diff/70001/src/objects-inl.h#newcode2703
src/objects-inl.h:2703: return Box::cast(Symbol::name())->value();
On 2013/10/29 12:47:26, Yang wrote:
could we assert in those accessors that the value is either undefined
or a
string?
Yeah, that is nasty. I decided to remove the whole Box hack and simply
add a flags field to the Symbol representation. Screw premature
optimisation.
https://codereview.chromium.org/48923002/diff/70001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/48923002/diff/70001/src/objects.h#newcode363
src/objects.h:363: \
On 2013/10/29 12:47:26, Yang wrote:
stray edit?
On purpose. :)
https://codereview.chromium.org/48923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
