On 2013/11/11 15:20:05, rossberg wrote:
https://codereview.chromium.org/48923002/diff/150001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/48923002/diff/150001/src/runtime.cc#newcode4868
src/runtime.cc:4868: if (name.is_null()) return Failure::Exception();
On 2013/11/05 14:54:21, Michael Starzinger wrote:
> nit: Please use RETURN_IF_EMPTY_HANDLE here.
Done.
https://codereview.chromium.org/48923002/diff/150001/src/runtime.cc#newcode4902
src/runtime.cc:4902: if (name.is_null()) return Failure::Exception();
On 2013/11/05 14:54:21, Michael Starzinger wrote:
> nit: Please use RETURN_IF_EMPTY_HANDLE here.
Done.
LGTM.
https://codereview.chromium.org/48923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
