On 2013/10/29 15:10:06, rossberg wrote:
On 2013/10/29 13:20:43, arv wrote:
> On 2013/10/29 12:01:16, rossberg wrote:
>
> > What's currently missing is the ability to install private properties
on
> object
> > templates. I can add that if it's required.
>
> That seems useful.
That will require a bit of work, though. So I'll not do it in this CL.
> My main concern is that we probably need to do cross realm registration
of
these
> as well (we need that for unique symbols too so we should keep this in
mind
when
> we do that). Today Blink bindings uses hidden properties, which are just
strings
> so they work in any realm/isolate. When we change these to private
state we
need
> to coordinate between the realms/isolates.
Yes. I don't really know what to do about that, but I'm open to ideas. :)
Instead of a flag field, why not a new map with the same instance type? We
got a
symbol_map(), how about a private_name_map()? If the instance type is the
same,
it would be treated the same way as a symbol in generated code and
IsSymbol()
passes.
https://codereview.chromium.org/48923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
