On 2013/11/05 13:50:54, Yang wrote:
Instead of a flag field, why not a new map with the same instance type?
We got
a
symbol_map(), how about a private_name_map()? If the instance type is the
same,
it would be treated the same way as a symbol in generated code and
IsSymbol()
passes.
That's what I started out with first, actually, but it's _hugely_ more
complicated, brittle, and also less efficient, because certain type tests
would
require additional comparisons. Moreover, there are only a couple of very
specific places (all having to do with reflection) where private and
non-private
symbols will behave differently, so it seems wrong to factor the difference
into
the instance type.
https://codereview.chromium.org/48923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
