One comment to address. I am fine with this fix (although I don't like it
very
much). The general problem seems to be that DeepCopy is just not
implemented as
efficiently as it could be.
For example the element kinds FAST_SMI_ELEMENTS and FAST_HOLEY_SMI_ELEMENTS
cannot contain any nested objects, so the iteration shouldn't be necessary.
But
I won't block this CL over it (windmill tilting mode deactivated).
https://codereview.chromium.org/77293003/diff/80001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/77293003/diff/80001/src/ast.h#newcode1607
src/ast.h:1607: enum Flags {
These flags are used for an interface between generated code and the
runtime, it's unrelated to the AST. Please move the flags somewhere more
appropriate. I would propose the runtime.h file. You could even use
bit-fields to encode the flags.
https://codereview.chromium.org/77293003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
