Hi Michael,
Okay I had another run at it, and was able to get to a 3% degrade and keep
the
general purpose code. I removed all the virtual dispatching and some
unnecessary
method calls.
I didn't yet move the ArrayLiteral flags to runtime.h, as this change is
already
big. I'd probably prefer to do that in a follow-up CL which also moves the
ObjectLiteral flags in a similar fashion. Very simple CL, just touches a
lot of
files.
Thanks much,
--Michael
https://codereview.chromium.org/77293003/diff/80001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/77293003/diff/80001/src/ast.h#newcode1607
src/ast.h:1607: enum Flags {
On 2013/11/20 21:26:19, Michael Starzinger wrote:
These flags are used for an interface between generated code and the
runtime,
it's unrelated to the AST. Please move the flags somewhere more
appropriate. I
would propose the runtime.h file. You could even use bit-fields to
encode the
flags.
In that case I should probably move ObjectLiteral::Flags to runtime.h as
well, because I'm simply making the array literal infrastructure
symmetrical with the object literal infrastructure.
https://codereview.chromium.org/77293003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
