LGTM. I give up!
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h
File src/allocation-site-scopes.h (right):
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h#newcode64
src/allocation-site-scopes.h:64: current_ =
Handle<AllocationSite>(*top_, isolate());
nit: If this is the only use-site of AllocationSiteContext::isolate then
we can get rid of that field completely (constructor without isolate is
usable).
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h#newcode115
src/allocation-site-scopes.h:115:
nit: Only one empty new-line.
https://codereview.chromium.org/77293003/diff/130001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/77293003/diff/130001/src/objects.h#newcode2528
src/objects.h:2528: bool hint_object_is_shallow_array = false);
Yay, more magic boolean parameters. :/
https://codereview.chromium.org/77293003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
