Thanks for the help and impetus to try harder :)
--Michael
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h
File src/allocation-site-scopes.h (right):
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h#newcode64
src/allocation-site-scopes.h:64: current_ =
Handle<AllocationSite>(*top_, isolate());
On 2013/11/22 20:07:16, Michael Starzinger wrote:
nit: If this is the only use-site of AllocationSiteContext::isolate
then we can
get rid of that field completely (constructor without isolate is
usable).
Hmm, the isolate does get used to access the factory and create
allocation sites in allocation-site-scopes.cc, so it gets to stay in the
boat.
https://codereview.chromium.org/77293003/diff/130001/src/allocation-site-scopes.h#newcode115
src/allocation-site-scopes.h:115:
On 2013/11/22 20:07:16, Michael Starzinger wrote:
nit: Only one empty new-line.
Done.
https://codereview.chromium.org/77293003/diff/130001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/77293003/diff/130001/src/objects.h#newcode2528
src/objects.h:2528: bool hint_object_is_shallow_array = false);
On 2013/11/22 20:07:16, Michael Starzinger wrote:
Yay, more magic boolean parameters. :/
Good point, I replaced it with an enum DeepCopyHints, that is passed
down into StructureWalk for consumption.
https://codereview.chromium.org/77293003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
