https://codereview.chromium.org/108083005/diff/90001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/108083005/diff/90001/src/runtime.cc#newcode5861
src/runtime.cc:5861: if ((key_type & Runtime::PROPERTY_KEY_SYMBOL) &&
On 2013/12/12 15:37:59, rossberg wrote:
How about splitting PropertyAttributes SYMBOLIC filter into
SYMBOLIC_PUBLIC and
SYMBOLIC_PRIVATE, so that you can avoid the filter post-processing
altogether?
(Except for interceptors of course, which you have to post-process
anyway, but
see below.)
You would only need to refine a couple of places in objects.cc
accordingly,
namely Map::NumberOfDescribedProperties and
JSObject::GetLocalPropertyNames, and
Dictionary<Shape, Key>::NumberOfElementsFilterAttributes.
I considered going down this route to handle string vs symbol but we
currently have 3 cases: strings, symbols and symbols+strings. If we also
want to filter out private symbols we need to add 2 bits to the bitmask.
I guess that is fine. I'll make the change and see what it looks like in
the end.
https://codereview.chromium.org/108083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
