Looking quite good now, just two more comments.
https://codereview.chromium.org/108083005/diff/130001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/108083005/diff/130001/src/objects.cc#newcode5915
src/objects.cc:5915: if (key->IsSymbol()) {
I would prefer to turn this inside out and do the filter checks first
and the (more expensive) instance type checks only if necessary.
https://codereview.chromium.org/108083005/diff/130001/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/108083005/diff/130001/src/v8natives.js#newcode1041
src/v8natives.js:1041: function FilterKeyNames(array, symbolsOnly) {
Why can't we fold this into the loop at line 1108, and avoid duplicating
the work?
https://codereview.chromium.org/108083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
