PTAL
https://codereview.chromium.org/108083005/diff/90001/src/macros.py
File src/macros.py (right):
https://codereview.chromium.org/108083005/diff/90001/src/macros.py#newcode162
src/macros.py:162: macro IS_PRIVATE(arg) = (%SymbolIsPrivate(arg));
On 2013/12/12 15:37:59, rossberg wrote:
Nit: s/arg/sym/
Done.
https://codereview.chromium.org/108083005/diff/90001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/108083005/diff/90001/src/runtime.cc#newcode5750
src/runtime.cc:5750: if (name->IsSymbol() &&
!static_cast<Symbol*>(name)->is_private()) {
On 2013/12/12 15:37:59, rossberg wrote:
Use Symbol::cast(name) here (and below).
But I had actually hoped that this whole function would be
unnecessary. See
below.
Done.
https://codereview.chromium.org/108083005/diff/90001/test/mjsunit/harmony/symbols.js
File test/mjsunit/harmony/symbols.js (right):
https://codereview.chromium.org/108083005/diff/90001/test/mjsunit/harmony/symbols.js#newcode276
test/mjsunit/harmony/symbols.js:276: function TestKeyHas(obj) {
On 2013/12/12 15:37:59, rossberg wrote:
Doh, how t.f. did this ever work???
There is a global variable called obj which happens to be the exact
same.
for (var in objs) {
var obj = objs[i];
TestKeyHas();
}
https://codereview.chromium.org/108083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
