LGTM
I'll try to land once the tree allows it (given the long line of CLs
currently
waiting that may not happen before my vacation, though -- just in case you
wonder ;) ).
https://codereview.chromium.org/108083005/diff/130001/src/v8natives.js
File src/v8natives.js (right):
https://codereview.chromium.org/108083005/diff/130001/src/v8natives.js#newcode1041
src/v8natives.js:1041: function FilterKeyNames(array, symbolsOnly) {
On 2013/12/18 18:07:12, arv wrote:
On 2013/12/18 16:50:12, rossberg wrote:
> Why can't we fold this into the loop at line 1108, and avoid
duplicating the
> work?
Done.
That would make more sense. And now I understand what you mean with
your
previous comment.
Yes, sorry if that was too cryptic.
https://codereview.chromium.org/108083005/diff/150001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/108083005/diff/150001/src/objects.cc#newcode5915
src/objects.cc:5915: if ((filter & SYMBOLIC) && key->IsSymbol()) {
On 2013/12/18 18:10:02, arv wrote:
One option here would be:
if (filter & (SYMBOLIC | SYMBOLIC | STRING)) {
bool is_symbol = key->IsSymbol();
...
}
return false;
I leave that up to you, I'm fine either way.
https://codereview.chromium.org/108083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
