Comments addressed, please take another look
(I am sorry, I had to rebase this)
https://codereview.chromium.org/150813004/diff/180001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/150813004/diff/180001/src/flag-definitions.h#newcode359
src/flag-definitions.h:359: "threshold for in-heap typed array")
On 2014/03/03 10:37:49, mvstanton wrote:
how about typed_array_max_size_in_heap.
Also, could you relate this constant to the max object size in the
heap with
ASSERTS somewhere appropriate? Obviously, 64 bytes is very small
compared to max
object size in new space, but an assert would offer long-lasting
protection.
Done.
https://codereview.chromium.org/150813004/diff/180001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/150813004/diff/180001/src/objects.cc#newcode16457
src/objects.cc:16457: printf("Materializing buffer!\n");
On 2014/03/03 10:37:49, mvstanton wrote:
Remove this printf().
Done.
https://codereview.chromium.org/150813004/diff/180001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/150813004/diff/180001/src/runtime.cc#newcode956
src/runtime.cc:956: holder->map()->Print();
On 2014/03/03 10:37:49, mvstanton wrote:
Remove this debugging code.
Done.
https://codereview.chromium.org/150813004/diff/180001/src/runtime.cc#newcode1063
src/runtime.cc:1063: memcpy(
On 2014/03/03 10:37:49, mvstanton wrote:
Could the memcpy code in this block be encapsulated into a
JSTypedArray::Copy()
function?
Maybe, but maybe in separate CL?
https://codereview.chromium.org/150813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
