LGTM. A few comments.
https://codereview.chromium.org/150813004/diff/180001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/150813004/diff/180001/src/runtime.cc#newcode1063
src/runtime.cc:1063: memcpy(
On 2014/03/10 09:20:35, Dmitry Lomov (chromium) wrote:
On 2014/03/03 10:37:49, mvstanton wrote:
> Could the memcpy code in this block be encapsulated into a
JSTypedArray::Copy()
> function?
Maybe, but maybe in separate CL?
Yep, okay. It seems weird to me to see primitive memory operations
operating on objects, the instinct is to hide that in implementation.
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc#newcode8466
src/hydrogen.cc:8466: static Handle<Map> TypedArrayMap(Isolate* isolate,
nit: add another space above this method.
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc#newcode8612
src/hydrogen.cc:8612:
A short comment here to explain what you are doing to compute
total_size.
https://codereview.chromium.org/150813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
