A few more comments. Would be nice to have that hydrogen code split up a
little
bit, given that it's so branchy, and there's not so much shared code.
https://codereview.chromium.org/150813004/diff/220001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/150813004/diff/220001/src/hydrogen.cc#newcode8583
src/hydrogen.cc:8583: HType::JSArray(),
Is this correct? I'd think only obj is HType::JSArray(), not the
elements.
https://codereview.chromium.org/150813004/diff/220001/src/hydrogen.cc#newcode8636
src/hydrogen.cc:8636: total_size->ClearFlag(HValue::kCanOverflow);
Is this the only place where we do alignment? If not, can we join that
code into an alignment helper function?
https://codereview.chromium.org/150813004/diff/220001/src/hydrogen.cc#newcode8642
src/hydrogen.cc:8642: Add<HAllocate>(total_size, HType::JSArray(),
Not a JSArray()
https://codereview.chromium.org/150813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
