PTAL (sorry, I had to rebase again)
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc#newcode8466
src/hydrogen.cc:8466: static Handle<Map> TypedArrayMap(Isolate* isolate,
On 2014/03/11 10:43:51, mvstanton wrote:
nit: add another space above this method.
Done.
https://codereview.chromium.org/150813004/diff/200001/src/hydrogen.cc#newcode8612
src/hydrogen.cc:8612:
On 2014/03/11 10:43:51, mvstanton wrote:
A short comment here to explain what you are doing to compute
total_size.
Done.
https://codereview.chromium.org/150813004/diff/200001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/150813004/diff/200001/src/objects.cc#newcode3260
src/objects.cc:3260: IsFastElementsKind(to_kind) ||
IsExternalArrayElementsKind(to_kind)
On 2014/03/10 14:15:34, Toon Verwaest wrote:
IsTransitionElementsKind(to_kind)?
No, this is not IsTransitionElementsKind.
https://codereview.chromium.org/150813004/diff/200001/src/objects.cc#newcode3277
src/objects.cc:3277: if (to_kind != kind &&
current_map->HasElementsTransition()) {
On 2014/03/10 14:15:34, Toon Verwaest wrote:
Can this only happen for DICTIONARY elements now? If so, can we
ASSERT?
Done.
https://codereview.chromium.org/150813004/diff/200001/src/objects.cc#newcode3282
src/objects.cc:3282: ASSERT(current_map->elements_kind() ==
target_kind);
On 2014/03/10 14:15:34, Toon Verwaest wrote:
This ASSERT is wrong afaict. If we didnt' have an elements transition
above, and
the target kind is DICTIONARY_ELEMENTS, the closest transition will
still be
whatever fast kind came right before that.
target_kind is not DICTIONARY_ELEMENTS in that case, target_kind is what
we were trying to reach (see above)
https://codereview.chromium.org/150813004/diff/200001/src/objects.cc#newcode3324
src/objects.cc:3324: if (kind != to_kind) {
On 2014/03/10 14:15:34, Toon Verwaest wrote:
Can this only happen for DICTIONARY elements now? If so, can we
ASSERT?
No, this happens at the end of all chains.
https://codereview.chromium.org/150813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
