https://codereview.chromium.org/189463019/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode840
include/v8.h:840: V8_INLINE bool SetReturnValueFrom(const K& key,
just SetReturnValue
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode847
include/v8.h:847: GetIsolate()->SetReference(parent, persistent);
create a private function to take a raw pointer
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode851
include/v8.h:851: UniquePersistent<V> Set(const K& key, Local<V> value)
{
this can't work, since the Set should 0 the unique, and if it didn't,
you'd be duplicating the cell and returning something that will
necessarily destroy it
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode856
include/v8.h:856: UniquePersistent<V> SetWithConfig(const K& key,
Local<V> value,
same here, plus this is not a very generic api
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode5855
include/v8.h:5855: returnValue.Set(Local<V>::New(isolate_,
FromVal(value)));
no new handle, just install it directly in return value
https://codereview.chromium.org/189463019/diff/1/include/v8.h#newcode5884
include/v8.h:5884: if (data.GetValue().IsEmpty()) { // Zombied handle.
remove this clause
https://codereview.chromium.org/189463019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
