looking good. watch the rebase!
https://codereview.chromium.org/189463019/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode853
include/v8.h:853: UniquePersistent<V> Set(const K& key,
UniquePersistent<V>& value) {
UniquePersistent should always be passed by value. not ref
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode853
include/v8.h:853: UniquePersistent<V> Set(const K& key,
UniquePersistent<V>& value) {
On 2014/03/10 19:00:46, vogelheim wrote:
I'd like to ASSERT(!value.IsWeak()), since the code makes the
assumption it can
SetWeak(..) on this value. How?
(Most parts of v8 seem to use ASSERT from src/checks.h, but I assume
one
shouldn't include stuff from src/... here and thus export that header
to all v8
clients?)
it's a bit annoying, but we are setting weak immediately, which means we
can do the assert internally. it may already be there
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode5872
include/v8.h:5872: if (hasValue) {
setting an empty returnvalue means settings the returnvalue's default
value
https://codereview.chromium.org/189463019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
