Errr, I forgot that V8 has its own tests and had to fix them first. :-/ It's only a minor change in test-api.cc, but PTAL.
On Tue, Mar 11, 2014 at 5:11 PM, <[email protected]> wrote: > > https://codereview.chromium.org/189463019/diff/40001/include/v8.h > File include/v8.h (right): > > https://codereview.chromium.org/189463019/diff/40001/ > include/v8.h#newcode819 > include/v8.h:819: template<class K, class V, class Traits> > On 2014/03/11 15:12:05, dcarney wrote: > >> need to add some small comments to the functions to explain what they >> > do > > Done. Please let me know if they're helpful. > > > https://codereview.chromium.org/189463019/diff/40001/ > include/v8.h#newcode5901 > include/v8.h:5901: Traits::Dispose(Release(value).Pass(), > data.GetIsolate(), impl, key); > On 2014/03/11 15:12:05, dcarney wrote: > >> all function which take an isolate parameter have it as the first >> > parameter by > >> convention >> > > Done. > > > https://codereview.chromium.org/189463019/diff/40001/ > include/v8.h#newcode5913 > include/v8.h:5913: SetInternal(GetDefaultValue()); > On 2014/03/11 15:12:05, dcarney wrote: > >> not much point in changing this if there's no if(V8_UNLIKELY) ... in >> > SetInternal > > Done. > > https://codereview.chromium.org/189463019/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
