https://codereview.chromium.org/189463019/diff/20001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode5890
include/v8.h:5890: }
we need to dispose the callback data for weak maps
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode5901
include/v8.h:5901: if (!data.GetValue().IsEmpty()) {
this cannot be empty
https://codereview.chromium.org/189463019/diff/20001/include/v8.h#newcode5902
include/v8.h:5902: Traits::DisposeByKey(impl, key);
we should be able to do all this with one disposeCallback, not 3
https://codereview.chromium.org/189463019/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
