Much cleaner!
Could you move the code to BuildNamedAccess though? That's the single
bottleneck
where all named property accesses go through.
https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc#newcode6730
src/hydrogen.cc:6730: (js_object->map()->is_frozen() ||
You don't need to special-case is_frozen(), such properties will be
read-only non-deleteable.
https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc#newcode6736
src/hydrogen.cc:6736: !value->IsCallable()) {
Why these cases? Can you introduce abstractions that make it clear what
these cases mean?
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
