On 2014/04/03 15:41:59, Toon Verwaest wrote:
Yes it does. But why do you limit it to just that case? Why not also
support
values that are eg loaded from the prototype chain (and hence predictable)
that
are not configurable / read-only?
Originally it was there because of the frozen check which was done on
the object itself only.
The code cannot be moved to BuildLoadNamedField because only Field loads
arrive
there
(so it wouldn't work for Math.PI, which is Normal). Can it be moved to
BuildMonomorphicAccess after the check for prototypes have been built?
Also, at this point, in the case the property was directly on the object,
isn't
the CheckMaps
that was added BuildNamedAccess just before the call to
BuildMonomorphicAccess
unnecessary?
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
