https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc#newcode6736
src/hydrogen.cc:6736: !value->IsCallable()) {
On 2014/04/02 14:51:47, Toon Verwaest wrote:
Why these cases? Can you introduce abstractions that make it clear
what these
cases mean?
The null check should actually be unnecessary (since the lookup is
found?).
About the hole check: I took a look at the different lookup types and it
looked like Normal, Field and Constant were the ones that can be applied
in this situation. I didn't find a method that checks for all of those
but I noticed GetLazyValue returns TheHole if the lookup type is not a
normal, a field or a constant. Should I make a method that checks of the
lookup type is one of these three types?
The callable check is there because if the value is a function, then
inlining its load and calling it causes crash. I think this is because
of some assumption is being violated somewhere but I don't know at this
time what it is. Should I add a fixme comment?
https://codereview.chromium.org/220163012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
