I moved the code which turned out to be handy in fixing the callable issue as
well:

in VisitCall, shortly after PushLoad is called it is checked if the function is a HConstant, and if it is, types->first() is called without checking the length
of the types (assumption is that there is at least 1 type).

However when using for example --always-opt this optimization used to return a
constant function when types->length is 0 and this causes a crash when
types->first() is called.

This is fixed by moving the optimization after the check has been done that
types->length() > 0.

https://codereview.chromium.org/220163012/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to