https://codereview.chromium.org/230363003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/230363003/diff/1/src/hydrogen.cc#newcode5826
src/hydrogen.cc:5826: if (access_type != STORE || !map->is_observed()) {
So this case will still trigger for observed maps, right?
Can we replace !map->is_observed with
CanInlinePropertyAccess(MapToType(map)) and add is_observed to the list
of criteria there? That way the semantics for PushLoad will be in sync
with what we are checking for here, and we'll be guaranteed that if
PushLoad actually can inline a load (eg an HConstant), it'll also be
added by this code to the types-list for VisitCall.
https://codereview.chromium.org/230363003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
