So we had to revert this CL cause it breaks
out/ia32.debug/d8 --test --random-seed=1773607309 --stress-opt --always-opt
--nohard-abort --nodead-code-elimination --nofold-constants
--enable-slow-asserts --debug-code --verify-heap --harmony-symbols
--harmony-collections --harmony-weak-collections --expose-gc
--allow-natives-syntax test/mjsunit/mjsunit.js
test/mjsunit/harmony/symbols.js
I've looked at it for a moment, and haven't immediately figured out the
exact
problem (apart from the fact that it's probably due to Realm in
TestRegistry).
It seems like "making up new type feedback" like we are doing in this CL is
probably pretty fragile at this moment, given that we encode lots of
knowledge
about what we can handle in the ICs, and expect Crankshaft to just follow
the
ICs.
The safest solution for now is probably to call BuildCallConstantFunction if
types->length() == 0, before checking NeedsWrappingFor. And less intrusive.
https://codereview.chromium.org/230363003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
