Ok yes, you are right. I can see this is correct.

But it would still be nice though to still move some of the logic into
CanInlinePropertyAccess, and pass in the access_type to that method. It would
filter out is_observed only if access_type == STORE.

I just want to ensure that we don't introduce such bugs later on, and have
everything correctly checked by CanInlinePropertyAccess.

https://codereview.chromium.org/230363003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to