So working on the check elimination patch, I think it will become overly
complicated if the checks are delayed. It would require
BuildMonomorphicAccess
to have the immutable load logic sprinkled all over the place and
necessisate
some repeated ugly checks as far as I can see. However if
BuildLoadNamedField
simply walked the checked_object and removed the unnecessary checks from the
instruction stream after the fact (is this possible?), all the logic could
cleanly stay in BuildLoadNamedField.
The actual inlining patch right now is very clean with all code in
BuildLoadNamedField, however it isn't possible to stay that way if we have
to
delay adding checks. I can put that patch up for review after you have
commited
this patch.
https://codereview.chromium.org/230363003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
