Mostly ok, but please rename all those 'deferred_promise' into
plain 'promise'.
https://codereview.chromium.org/249503002/diff/1/src/debug-debugger.js
File src/debug-debugger.js (right):
https://codereview.chromium.org/249503002/diff/1/src/debug-debugger.js#newcode1097
src/debug-debugger.js:1097: function MakeExceptionEvent(exec_state,
exception, uncaught, deferred_promise) {
And here...
https://codereview.chromium.org/249503002/diff/1/src/debug-debugger.js#newcode1130
src/debug-debugger.js:1130: ExceptionEvent.prototype.deferred_promise =
function() {
And so on...
https://codereview.chromium.org/249503002/diff/1/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/249503002/diff/1/src/debug.cc#newcode2671
src/debug.cc:2671: Handle<Object> deferred_promise) {
And here.
https://codereview.chromium.org/249503002/diff/1/src/debug.h
File src/debug.h (right):
https://codereview.chromium.org/249503002/diff/1/src/debug.h#newcode798
src/debug.h:798: Handle<Object> deferred_promise);
Nit: any reason not to just name this 'promise'?
https://codereview.chromium.org/249503002/diff/1/src/debug.h#newcode806
src/debug.h:806: Handle<Object> deferred_promise =
Handle<Object>::null());
Same here.
https://codereview.chromium.org/249503002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/249503002/diff/1/src/promise.js#newcode200
src/promise.js:200: // Reject handler threw (must be a custom one).
"must have been"
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc#newcode5657
src/runtime.cc:5657: HandleScope scope(isolate);
Why have both a SHS and a HS in the same function?
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc#newcode5659
src/runtime.cc:5659: CONVERT_ARG_HANDLE_CHECKED(Object,
deferred_promise, 1);
One more.
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-caught.js
File test/mjsunit/es6/debug-promises-caught.js (right):
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-caught.js#newcode39
test/mjsunit/es6/debug-promises-caught.js:39: print(e + "\n" + e.stack);
Maybe add "Unexpected exception: ".
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-uncaught.js
File test/mjsunit/es6/debug-promises-uncaught.js (right):
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-uncaught.js#newcode36
test/mjsunit/es6/debug-promises-uncaught.js:36: assertEquals('object',
typeof event_data.deferred_promise());
You could more specifically test 'event_data.promise() instanceof
Promise' here.
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-uncaught.js#newcode45
test/mjsunit/es6/debug-promises-uncaught.js:45: print(e + "\n" +
e.stack);
Maybe add "Unexpected exception: ".
https://codereview.chromium.org/249503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
