Looks OK overall, +aandrey who may have some input.
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc#newcode5660
src/runtime.cc:5660: isolate->debugger()->OnException(exception, false,
deferred_promise);
It might make sense to report the exception as uncaught=true here in
case there is no catch handler on the promise yet.
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-caught.js
File test/mjsunit/es6/debug-promises-caught.js (right):
https://codereview.chromium.org/249503002/diff/1/test/mjsunit/es6/debug-promises-caught.js#newcode29
test/mjsunit/es6/debug-promises-caught.js:29: assertEquals(["resolve",
"end main", "throw"], log);
Just curious: I'd expect "end main" to be logged before "resolve" or
does Promise evaluate synchronously in this case?
https://codereview.chromium.org/249503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
