Couple of comments, if addressed then lgtm.
https://codereview.chromium.org/279773002/diff/100001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/279773002/diff/100001/src/builtins.cc#newcode387
src/builtins.cc:387: if (to_add > 0 &&
JSArray::ChangeOfReadOnlyLength(array, len + to_add)) {
The name of this function is odd, how about JSArray::CanChangeLength()?
Also, it definitely seems like we need it, but I wonder how costly the
lookup of the length property attributes is: okay from a performance
view?
https://codereview.chromium.org/279773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
