Thank you, I uploaded new patch.
Note that I changed KeyedStoreIC in ic.cc: there was a bug where we would
set
the ic target even in case when runtime returned exception.
https://codereview.chromium.org/279773002/diff/120001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/279773002/diff/120001/src/builtins.cc#newcode390
src/builtins.cc:390: JSArray::ReadOnlyLengthError(array));
On 2014/05/14 08:30:48, Michael Starzinger wrote:
As discussed offline: Instead of handling this corner-case here in the
optimized
version, could we instead call out to the JS builtin reference
implementation
instead? This would make the optimized path simpler.
Replaced RETURN_FAILURE_ON_EXCEPTION(..) with call to JS builtin. I
thought about simplifying the condition as well (only checking for
read-only length), but left it unchanged because it allows to avoid
length lookup when the index is within bounds.
https://codereview.chromium.org/279773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
